Home Original page

Fix test_duplicate_sig_keyids by loosebazooka · Pull Request #852 · sigstore/sigstore-java

@loosebazooka

This isn't a security concern, our looping didn't actually allow re-use of keys. But we weren't exactly according to spec.

patflynn

@@ -234,16 +235,23 @@ void verifyDelegate(
Map<String, Key> publicKeys,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github really doesn't want me commenting on non changed lines or something, but line 230 @throws is I guess out of date?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot, yeah lemme fix that

patflynn

@loosebazooka 

This isn't a security concern, our looping didn't actually allow
re-use of keys. But we weren't exactly according to spec.

Signed-off-by: Appu Goundan <appu@google.com>

patflynn