Add signing config parsers by loosebazooka · Pull Request #956 · sigstore/sigstore-java
Summary
First part of #954
Add in class to store the signing config to later plumb into our client parts
Release Note
Documentation
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
Signed-off-by: Appu Goundan <appu@google.com>
| * @param apiVersions an list of api version this clients supports | ||
| * @return A service if found | ||
| */ | ||
| static Optional<Service> select(List<Service> services, List<Integer> apiVersions) { |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters