Add timestamp client and verifier by aaronlew02 · Pull Request #960 · sigstore/sigstore-java
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great work! I can't speak much to Java style, I'll let Appu chime in there.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some preliminary comments, I'll go over the logic in TimestampClientHttp on a second pass.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just some minor things
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters