Add RFC3161 timestamps to bundle reader and writer by aaronlew02 · Pull Request #978 · sigstore/sigstore-java

Conversation

@aaronlew02

Partially addresses #959

Summary

This change allows for the inclusion of RFC3161 timestamps in a Bundle via the BundleReader and BundleWriter.

loosebazooka

loosebazooka

"Exactly 1 rekor entry must be present in the signing result");
}
builder.addTlogEntries(buildTlogEntries(bundle.getEntries().get(0)));
Optional<TimestampVerificationData> timestampData =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be an Optional.ifPresent shortcut you can use here

buildTimestampVerificationData(bundle.getTimestamps()).ifPresent(data -> builder.setTimestampVerificationData(data)
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>

loosebazooka

2 participants

@aaronlew02 @loosebazooka