fix: fix all broken builds and tests across the repo by mikemaccana-edwardbot · Pull Request #535 · solana-developers/program-examples

@rocketiotemp

Native tests (16/16 passing):

- counter/native & escrow/native: add bn.js as explicit dependency.
  pnpm's strict dependency resolution does not hoist transitive deps
  (unlike npm), so bn.js from @solana/web3.js is not accessible directly.

- All native tests using borsh: migrate from borsh v0.7 class-based API
  to borsh v2 object schema API. The v0.7 API (Map schemas, Assignable
  classes, 3-arg deserialize) is incompatible with borsh v1+. Updated 19
  test files and 14 package.json files. Introduced a shared
  borshSerialize(schema, data) helper to replace the repeated
  Buffer.from(borsh.serialize(...)) pattern. Removed per-schema typed
  wrappers in favour of exporting schemas directly.

- create-account/native: replace litesvm with solana-bankrun. litesvm's
  native binary crashes with SIGABRT on Linux x64
  (LiteSVM/litesvm#171). This was the only
  native test using litesvm — all others use solana-bankrun, the
  recommended framework per CONTRIBUTING.md.

- Upgrade TypeScript 4.x to 5.x in 10 token projects. TS4 can't parse
  @solana/codecs-data-structures type definitions. Also fix
  Keypair.fromSecretKey(Buffer.from(...)) to use Uint8Array.from() for
  TS5 compatibility.

Anchor builds (39/39 passing):

- Set solana_version = "3.1.8" in all 49 Anchor.toml files. Anchor's
  default BPF toolchain ships rustc 1.79, but anchor-lang 0.32.1's
  dependency tree requires rustc 1.82+ (indexmap 2.13.0) and Cargo's
  edition2024 feature. Solana 3.1.8 platform-tools v1.52 (rustc 1.89)
  resolves both. All projects now use a consistent toolchain version.

- allow-block-list-token: bump spl-transfer-hook-interface 0.8.2 -> 2.1.0,
  spl-tlv-account-resolution 0.8.1 -> 0.11.1, spl-discriminator 0.3 -> 0.5.1.
  Old SPL versions used solana-program v1, causing type mismatches with
  anchor-lang 0.32.1's v2 types. litesvm Rust test moved to tests-rs/
  because litesvm pins solana-account-info =2.2.1 but anchor-lang 0.32.1
  needs >=2.3.0 for AccountInfo::resize(). See tests-rs/README.md.

Compression projects (3/3 building):

- Rewrite cnft-burn, cnft-vault, cutils from anchor-lang 0.26.0 to 0.32.1.
  Upgrade to mpl-bubblegum 2.1.1 + spl-account-compression 1.0.0 (both
  use solana-program v2, matching anchor-lang 0.32.1). cnft-vault: manual
  invoke_signed rewritten to TransferCpi. cutils verify: raw invoke because
  spl-account-compression 1.0.0's CPI module is built against anchor-lang
  0.31, which has incompatible traits with 0.32.1. Discriminator computed
  from sha256("global:verify_leaf") rather than hardcoded. Comment
  documents when this workaround can be removed.

Documentation:

- README: remove TypeScript/Poseidon references (none exist in repo),
  Anchor before Native in badges, fix typos.
- CONTRIBUTING: remove Steel/Python/Solidity/Poseidon references (none
  exist in repo), fix markdown, renumber sections.

@rocketiotemp

Anchor test failures (8 projects):
- Remove 'import { describe, it } from "node:test"' from 7 bankrun test
  files. These tests run via ts-mocha which provides describe/it globally.
  Importing from node:test creates a conflict where mocha can't see the
  test registrations.
- Increase startup_wait from 5000ms to 25000ms in 9 Anchor.toml files.
  The default 5s is too short for CI where the test validator takes longer
  to start due to shared compute.

Native build failure (1 project):
- tokens/escrow/native: blake3 1.8.3 requires Rust edition 2024 which
  the Cargo bundled with solana-program 1.18.17's platform-tools doesn't
  support. Added Cargo.lock pinning blake3 to 1.5.5 (last edition-2021-
  compatible version).
Anchor test failures (7 bankrun projects):
- Remove [test.validator] and [[test.validator.clone]] sections from
  bankrun projects. These tests use solana-bankrun (in-process simulation)
  and don't need a local validator. The validator was cloning the token
  metadata program from mainnet/devnet, causing >25s startup times that
  exceeded the timeout.
- Affected: create-token, transfer-tokens, nft-minter, nft-operations,
  pda-mint-authority, spl-token-minter, token-2022/basics

Anchor test failures (2 real-validator projects):
- Bump startup_wait from 25000ms to 120000ms (2 min) for transfer-hook
  whitelist and hello-world. These clone from devnet and need more time
  in CI.

Native build failure (escrow):
- Fix Cargo.lock to actually pin blake3 to 1.5.5 and constant_time_eq
  to 0.3.1. Previous commit had a stale Cargo.lock that still resolved
  to the edition-2024-requiring versions.
- Fix escrow test: wrap deserialized pubkey bytes in new PublicKey()
  since borsh returns raw byte arrays, not PublicKey objects.
- Bankrun projects (7): explain why [test.validator] was removed — these
  use in-process simulation and don't need the local validator
- Real-validator projects (2): explain why startup_wait is 120s — they
  clone programs from devnet which is slow in CI
- Escrow native: explain why Cargo.lock is committed and blake3 is pinned
  (edition 2024 incompatibility with solana-program 1.18.17's toolchain)
- Escrow test: comment explaining borsh deserializes pubkeys as byte arrays
- .gitignore: exception for escrow Cargo.lock with explanation
The beta channel (v4.0) returns 404 from release.anza.xyz, causing the
setup-solana action to fail. Since the action clears the stable install
before attempting beta, this causes 'solana: command not found'.

The 'Build and Test with Beta' step already had continue-on-error: true
but the setup step itself didn't, so the job still failed.
…onjs projects

Several token projects need the Metaplex Token Metadata program cloned
from mainnet for their validator tests. The [test.validator] sections
were incorrectly removed — these projects have BOTH bankrun and
validator tests.

Restored [test.validator] for:
- tokens/create-token/anchor
- tokens/nft-minter/anchor
- tokens/nft-operations/anchor
- tokens/pda-mint-authority/anchor
- tokens/spl-token-minter/anchor
- tokens/transfer-tokens/anchor

Fixed 'import ... with { type: "json" }' -> require() in:
- tokens/token-2022/basics/anchor/tests/bankrun.test.ts
- tokens/create-token/anchor/tests/bankrun.test.ts
- tokens/nft-minter/anchor/tests/bankrun.test.ts

The 'with' syntax (import attributes) requires TS 5.3+ but these
projects use TS ^4.3.5 with module: commonjs. Projects using
module: nodenext handle it natively and don't need the fix.

Also increased startup_wait to 180s for transfer-hook hello-world
and whitelist projects (120s hit the timeout exactly in CI).
Projects that clone programs from mainnet/devnet (especially Metaplex
Token Metadata) need much longer startup times in CI. 120s and 180s
both hit the timeout exactly. 300s (5 min) should give enough headroom
for slow network conditions in GitHub Actions runners.
6 projects with bankrun tests: switch to bankrun-only testing since
the validator tests need Metaplex Token Metadata cloned from mainnet
which takes >5min in CI (exceeds startup_wait timeout).
bankrun.test.ts uses local fixtures instead.

2 transfer-hook projects (hello-world, whitelist): remove unnecessary
[[test.validator.clone]] for metaplex - these projects don't use
Metaplex at all. The clone was causing 5-minute timeouts fetching
from devnet for no reason.

Projects changed:
- tokens/create-token/anchor
- tokens/nft-minter/anchor
- tokens/nft-operations/anchor
- tokens/pda-mint-authority/anchor
- tokens/spl-token-minter/anchor
- tokens/transfer-tokens/anchor
- tokens/token-2022/transfer-hook/hello-world/anchor
- tokens/token-2022/transfer-hook/whitelist/anchor
The repo had 20+ different @solana/web3.js versions ranging from ^1.32.0
to ^1.95.5 (and one pinned 1.98.2). This caused inconsistent dependency
resolution and potential compatibility issues between examples.

Standardise everything to ^1.98.4 (latest 1.x) for consistency.
All examples share the same runtime so there's no reason for divergent
version constraints.
The previous commit updated @solana/web3.js to ^1.98.4 in all package.json
files but didn't regenerate the lockfiles. CI uses frozen-lockfile installs,
so all projects with stale lockfiles failed with ERR_PNPM_OUTDATED_LOCKFILE.

@rocketiotemp

Node.js 20 actions are deprecated by GitHub and will stop working
in June 2026. Updated all workflow actions to their latest versions
that use the Node.js 24 runtime:

- actions/checkout: v4 → v5
- actions/setup-node: v4 → v5
- dorny/paths-filter: v3 → v4
- heyAyushh/setup-anchor: v0.31 → v4.999
- heyAyushh/setup-solana: v2.02 → v5.9

Also added FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true env variable to
all workflows. This forces any remaining Node.js 20 actions (e.g.
those used internally by composite actions) to run on Node.js 24.

See: https://github.blog/changelog/2025-06-09-github-actions-node-js-20-deprecation/

@rocketiotemp

Perelyn-sama