add hello solana asm example by Perelyn-sama · Pull Request #538 · solana-developers/program-examples
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small things to change :) thx for the work
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re on the solana dependency added -> Yes, but that dependency isn't used anywhere in your code itself
re on the solana dependency added -> Yes, but that dependency isn't used anywhere in your code itself
fair, removed.
Also, thanks for the reviews. feels good to be making progress :)
@Perelyn-sama of course ! and can you fix the conflict? after that I think we'll be good to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters