Fix#95: support host and port arguments configuration for different DBMSs in SQLancer · Pull Request #315 · sqlancer/sqlancer
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these options are not supported by all DBMSs (yet): Would it be possible to insert a (static) check method that is called by every provider that does not support these? This is optional for this PR, but it might be a useful future improvement.
We modify the description information to remind users that this value will be reset by the system. Is it feasible?
@Parameter(names = "--host", description = "The host used to log into the DBMS. If the user does not specify this value, it will be reset to localhost by the system")
private String host = "sqlancer"; // NOPMD
@Parameter(names = "--host", description = "The host used to log into the DBMS. If the user does not specify this value, it will be reset to database system default port by the system")
private String host = "sqlancer"; // NOPMD
In fact, another important function of placeholders is to facilitate us to determine whether the user has specified this parameter, so invalid values should be used as placeholders. The value sqlancer is a good choice. These two values are actually essentially different from username and password. The default of host is localhost. The default of port is database parameter.
what do you think? :) (-: