Home Original page

update plotwindow's selection in tablebrowser by anandsanto · Pull Request #2644 · sqlitebrowser/sqlitebrowser

@anandsanto

Selections made in plot window are presently not shown in the table browser. This is a feature that was present in earlier versions but was broken after 834e650.

This is a feature that was already present but was
broken after 834e650

@mgrojo

Thanks!

This change sounded familiar, and in fact it's the same as 223a7cd

@MKleusberg, I haven't investigated it, but I suppose that this line disappeared in one of your optimizations. Would restoring it in this way affect performance?

@anandsanto

Oh, I bisected till I found that 834e650 was the one that removed this feature. Didn't realize this change was added again in 223a7cd and removed later on for whatever reasons.

However, I'd like to emphasize that it's a great feature to have and I have been missing this feature in the recent builds. Even if this is not the optimal way to add this feature, I hope you find a way to add this feature again. Thanks

@mgrojo

Let's merge this as commented in #2678. Thanks for taking care of this, @anandsanto!