ROX-33574: Don't forget to configure scanner pull secrets by rhacs-bot · Pull Request #19449 · stackrox/stackrox
(cherry picked from commit 1331603)
⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 28322140 | Triggered | Username Password | d10a6f6 | pkg/helm/charts/tests/securedclusterservices/testdata/helmtest/image-pull-secrets.test.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Images are ready for the commit at d10a6f6.
To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.0-1-gd10a6f6bf1.
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.37%. Comparing base (7b817fa) to head (d10a6f6).
Additional details and impacted files
@@ Coverage Diff @@ ## release-4.10 #19449 +/- ## ================================================ - Coverage 49.38% 49.37% -0.01% ================================================ Files 2660 2660 Lines 200669 200669 ================================================ - Hits 99103 99086 -17 - Misses 94125 94138 +13 - Partials 7441 7445 +4
| Flag | Coverage Δ | |
|---|---|---|
| go-unit-tests | 49.37% <ø> (-0.01%) |
⬇️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@rhacs-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/gke-nongroovy-compatibility-tests | d10a6f6 | link | false | /test gke-nongroovy-compatibility-tests |
| ci/prow/ocp-dev-preview-qa-e2e-tests | d10a6f6 | link | false | /test ocp-dev-preview-qa-e2e-tests |
| ci/prow/ocp-dev-preview-scanner-v4-install-tests | d10a6f6 | link | false | /test ocp-dev-preview-scanner-v4-install-tests |
Full PR test history. Your PR dashboard.
Details
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters