Home Original page

ROX-33597: Update svgo 2.x to 2.8.2 by dvail · Pull Request #19457 · stackrox/stackrox

@dvail

Description

As titled.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI

@dvail

@rhacs-bot

Images are ready for the commit at 25ac17b.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.9-1-g25ac17b4eb.

@codecov

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.73%. Comparing base (9d37ef0) to head (25ac17b).

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-4.8   #19457      +/-   ##
===============================================
- Coverage        48.73%   48.73%   -0.01%     
===============================================
  Files             2595     2595              
  Lines           190828   190828              
===============================================
- Hits             93005    92994      -11     
- Misses           90511    90519       +8     
- Partials          7312     7315       +3
Flag Coverage Δ
go-unit-tests 48.73% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci

@dvail: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-next-candidate-ui-e2e-tests 25ac17b link false /test ocp-next-candidate-ui-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pedrottimark