Refactoring: Fix sonarQube issues in JSONObject by marilynel · Pull Request #1005 · stleary/JSON-java
What problem does this code solve?
Address sonarqube issues in JSONObject. More to come.
Does the code still compile with Java6?
Yes
Risks
Low
Changes to the API?
No
Will this require a new release?
No
Should the documentation be updated?
No
Does it break the unit tests?
No. There is one unit testcase that has been breaking in local builds, this was fixed. More investigation is needed, but not for this PR.
Was any code refactored in this commit?
All of the code changes were for refactoring.
Review status
APPROVED
Starting 3-day comment window.
@marilynel Please fix the JavaDoc comments, if you get a chance before merge. Otherwise, they can be included in the next batch of SonarQube fixes. Also, not sure why SonarQube is reporting a new issue for code that hasn't changed in more than a decade. Will address it with the rest of the issues.