Newton-Raphson for NEMO temperature computations by WallyMaier · Pull Request #1627 · su2code/SU2
Proposed Changes
This replaces the bisection method in NEMO to compute the Tve values. The NR solver should be faster and offer some speed up, I believe the ComputeTemperatures function is the slowest in NEMO.
So I have some cases running to highlight the speedup (hopefully not a slowdown). From a quick glance, it seems the iteration time is very sensitive to the scaling factor.
Lastly, this will probably destroy the regression tests for NEMO, since our temperatures will be slightly different now.
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
- I am submitting my contribution to the develop branch.
- My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags, or simply --warnlevel=2 when using meson).
- My contribution is commented and consistent with SU2 style.
- I have added a test case that demonstrates my contribution, if necessary.
- I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.