Proposed Changes

This new feature aims to get viscosity and conductivity from CoolProp library.

Related Work

This project is an extension of PR #1806

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

• I am submitting my contribution to the develop branch.
• My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
• My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
• I have added a test case that demonstrates my contribution, if necessary.
• I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Hi, I can build this new feature and run simulation with

VISCOSITY_MODEL= COOLPROP
CONDUCTIVITY_MODEL= CONSTANT_COOLPROP

But the building process on github failed.

I need your help :)

Thank you.

Hi, I can build this new feature and run simulation with

VISCOSITY_MODEL= COOLPROP CONDUCTIVITY_MODEL= CONSTANT_COOLPROP

But the building process on github failed.

I need your help :)

Thank you.

I suggest to click on 'Details' next to each of the regression tests and see why it fails. I saw that there are at least 2 different errors, one was for instance 'coolprop.h' not found.

Hi, I can build this new feature and run simulation with
VISCOSITY_MODEL= COOLPROP CONDUCTIVITY_MODEL= CONSTANT_COOLPROP
But the building process on github failed.
I need your help :)
Thank you.

I suggest to click on 'Details' next to each of the regression tests and see why it fails. I saw that there are at least 2 different errors, one was for instance 'coolprop.h' not found.

You are right, I am trying to solve these errors one by one.

Thank you for your help.

@pcarruscag

Hi, there is an issue related to code factor.

It is said that (SU2_CFD/src/solvers/CIncEulerSolver.cpp) is complex code.

I tried to find solution by google, but still failed.

Do you have an suggestion? Thank you.

That's ok, I think that's some kind of bug in code factor, we can't do much about that warning.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>

Please modify the existing CoolProp test case to use the models, or add a new one.

I add a new config file to include the CoolProp viscosity and conductivity model. I use the same mesh, so no new mesh is required.