Adding thermal conductivities to NEMO output by WallyMaier · Pull Request #1889 · su2code/SU2

Conversation

@WallyMaier

Proposed Changes

This PR adds the non-constant thermal conductivities to the NEMO output.

Related Work

Discussion #1888

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

WallyMaier

pcarruscag

WallyMaier

WallyMaier

jtneedels

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I guess I'm curious if this is something we want to push into the base code though. To address LDK29, they would want this for the surface output.

@WallyMaier

So this will output the surface as well.

Im thinking as more surface effects are looked at, it will become important. Especially when comparing different transport models. I know I used it extensively for in the RANS models.

WallyMaier

@jtneedels

So this will output the surface as well.

Im thinking as more surface effects are looked at, it will become important. Especially when comparing different transport models. I know I used it extensively for in the RANS models.

Good point, I was mis-remembering there to be separate AddSurfaceOutput....

Ok sounds good to me then!

pcarruscag

Labels