Corrections to SA-NEG-R and SA model by rois1995 · Pull Request #2014 · su2code/SU2
Proposed Changes
Hi, I found some problems with the implementation of the SA-NEG and SA-NEG-R models wrt to what is described on TMR. Plus, I found a suggestion on the computation of the SHat variable to avoid clipping for negative values (also reported on TMR).
Related Work
- Implementation of new computation of SHat (Jacobian was computed by hand and is somewhat complex. Probably I could derive a simplified formulation)
- Added CRot constant for SA-R model
- Modified computation of var.S for the combination SA-NEG-R
- Slightly change the computation of muT from nu_tilde: now muT = 0 if nu_tilde <0. Before it was muT = max(muT, 0.0), which should not always coincide with nu_tilde > 0.
- Not related to SA: added viscous drag as output in the history file.
I should also try to add the maximum value of nu_tilde within the mesh to the history file, although I still have to implement it.
PR Checklist
- I am submitting my contribution to the develop branch.
- My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
- My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
- I have added a test case that demonstrates my contribution, if necessary.
- I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.