Supersonic inlet profile by pcarruscag · Pull Request #2327 · su2code/SU2
Hi @ShukaiWang1110, In SU2, we have different branches:
- The master branch are official releases. They get a version number and are also released with precompiled executables. This is for instance "SU2 v.8.0"
- A new master branch is created from the latest develop branch. Developers are usually working with the develop branch to have access to the latest implementations. New implementations are committed to the develop branch.
- When a developer wants to implement something new, they create a new branch from develop, implement their thing, and merge it again with develop. You see that happening here, in the top of the page you see
pcarruscag wants to merge 2 commits into develop from supersonic_profile
You see in the section Files Changed the changes compared to the current develop branch. This shows that this branch is up to date with current develop, only the new changes for the inlet profile show up.
I did not go through the code yet, but when you run it without having an inlet.dat file present, it should create one for you filled with a uniform profile. When you then use this file unaltered, does that work?Hi, I got how the branches work. In this case, I first downloaded the 'develop' branch to make sure everything is consitent with Pedro, and then I downloaded and replaced the 6 new committed files that related to the supersonic inlet profile development. The code should be totally the same at this point. And I did a flat plate test, which actually I need to fill a uniform profile, since the code would only generated an empty one. However, a segment error still occurs, and I attched the error file with Valgrind output. The test files are on the above conversations so that you may also take a try. Thanks for the help! error.txt
From the error, I think The SU2_CFD encountered an invalid memory read operation during an attempt to read the inletUNI.dat file, causing the program to crash with a segment error (SIGSEGV). The specific error occurs in the CConfig::GetInletPtotal function, which seems attempts to access memory that has not been properly initialized or allocated. Any ideas? @pcarruscag @bigfooted