Fix Linux arm64 regression workflow by bmunguia · Pull Request #2607 · su2code/SU2
Proposed Changes
The workflow "Regression tests running on Linux ARM64" seems to have always timed out after 24 hours of looking for a runner, and has attempted to run on every merge into develop.
This PR:
- Fixes the runner name according to the available runners for public repos
- Adds a
workflow_dispatchtrigger to allow manually triggering on either of the available runners - Updates the test values for aarch64 regressions
- Adds a
TestCase.tol_aarch64in the regression Python script for cases where a larger tolerance is needed than in the x86_64 regressions
PR Checklist
- I am submitting my contribution to the develop branch.
- My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
- My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
- I used the pre-commit hook to prevent dirty commits and used
pre-commit run --allto format old commits. - I have added a test case that demonstrates my contribution, if necessary.
- I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.
Regarding triggers, I was unsure if I should make it
- on push to develop (like it was)
- on push/PR to develop/master (like the other regressions)
- manual (like I added)
If we don't care about maintaining these regressions, maybe we should just make it manual so it doesn't hang for 24 hours and fail every time there's a push to develop
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was using private runners that someone was donating, I was not able to get in touch with the original developer to fix it. So, thanks for the fix.
If there are standard github runners now we can keep it on merge with develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters