Address review comments from PR #2539 - LU_SGS Preconditioner by digvijay-y · Pull Request #2751 · su2code/SU2
Proposed Changes
Give a brief overview of your contribution here in a few sentences.
Changes request by @pcarruscag in PR #2539 made by @areenraj .
Changes made:
- nPartition → nGraphPartition in CGeometry.hpp
- Removed default constructor CLevelScheduling() = delete, CalculateChain signature, levelOffsets changed from non-const to const
- Reorder refactored — inversePointList parameter renamed to reorderedPointList, argument order swapped
inversePointList removed as class member declaration + reserve call, now declared locally inside Partition()
levels.reserve → levels.resize with 0ul initialization - Reorder call order flipped — pointList = std::move(inversePointList) now happens after Reorder
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
#2539
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
- I am submitting my contribution to the develop branch.
- My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
- My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
- I used the pre-commit hook to prevent dirty commits and used
pre-commit run --allto format old commits. - I have added a test case that demonstrates my contribution, if necessary.
- I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.