fix(branching): ensure pgmq extension creation syntax is dumped on branch operations by dumko2001 · Pull Request #4940

fix(branching): ensure pgmq extension creation syntax is dumped on branch operations by dumko2001 · Pull Request #4940 · supabase/cli

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 6bc9fcbd-e565-4915-b3ac-8cb186f9c5a0

📥 Commits

Reviewing files that changed from the base of the PR and between db0bfe7 and 7abbfe3.

📒 Files selected for processing (3)

pkg/migration/drop.go
pkg/migration/queries/drop.sql
pkg/migration/scripts/dump_schema.sh

💤 Files with no reviewable changes (1)

pkg/migration/drop.go

📝 Walkthrough

Summary by CodeRabbit

Bug Fixes
- Refined pgmq schema management during migrations and dump operations to ensure proper schema creation and association.

Walkthrough

The changes modify how the pgmq schema is handled in the migration system. The pgmq entry was removed from the ManagedSchemas exclusion list in drop.go, and the corresponding SQL schema-dropping filter now omits pgmq from its exclusion clause. Additionally, the dump_schema.sh script was updated to change the pgmq extension handling during pg_dump—instead of appending a semicolon, it now creates the pgmq schema explicitly and applies a WITH SCHEMA clause to the CREATE EXTENSION command.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}