Implement a basic RESP3Token parser by Joannis · Pull Request #71 · swift-server/RediStack

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add an index here? That way we can correlate the error back to a specific location in the received ByteBuffer. Definitely helps debugging should this ever trigger

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do understand and appreciate the feature request. However is that something that we can put off for later?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, do you want me to make an issue for this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah go for it!