Add default database name to MongoDB Atlas by blancqua · Pull Request #10034 · testcontainers/testcontainers-java

@blancqua

luketn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Only change I would recommend is using the term 'database specific connection string' because:

  1. connectionString is more consistent with the existing getConnectionString() method
  2. the database specific connection string is not related to replica sets. it's just a way to include the database name in the connection string rather than having to select a database afterward

@blancqua

Sounds good to me! Included your suggestion and merged them all together in 1 commit.

eddumelendez

@blancqua

@eddumelendez, spotless changes applied. One flaky test (ArtemisContainerTest), but I don't see this having anything to do with the proposed change.

Kind regards, Wouter

@blancqua

Hi guys, anything else you would like to see changed before this can be merged?

luketn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@blancqua

Hello @eddumelendez, @luketn. I'm reaching out since this is now open for a while. Anything still holding you back from merging this?

Kind regards,
Wouter

@eddumelendez

@eddumelendez