Add default database name to MongoDB Atlas by blancqua · Pull Request #10034 · testcontainers/testcontainers-java
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Only change I would recommend is using the term 'database specific connection string' because:
- connectionString is more consistent with the existing getConnectionString() method
- the database specific connection string is not related to replica sets. it's just a way to include the database name in the connection string rather than having to select a database afterward
@eddumelendez, spotless changes applied. One flaky test (ArtemisContainerTest), but I don't see this having anything to do with the proposed change.
Kind regards, Wouter
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Hello @eddumelendez, @luketn. I'm reaching out since this is now open for a while. Anything still holding you back from merging this?
Kind regards,
Wouter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters