Home Original page

Add Oracle Free module by collinmurd · Pull Request #1242 · testcontainers/testcontainers-node

@collinmurd

Adds a module for Oracle DB support using oracle free. Follows similar implementation to the existing Java and Python modules, which utilize these images

@netlify

cristianrgreco

cristianrgreco

@cristianrgreco

@collinmurd

@cristianrgreco

Ah I didn't know, makes sense then, please disregard my last comment

@collinmurd

@collinmurd

@collinmurd

cristianrgreco

cristianrgreco

@collinmurd

@collinmurd

@cristianrgreco

@collinmurd

@collinmurd build failed

Sorry, totally missed it

Still researching. Tests work locally with Docker so I suspect is a resource thing

@collinmurd

@cristianrgreco

I would make the change myself but I don't have write permission. The other modules spin up a container per test to enable running in parallel. The issue here is there's a single container for all the tests, so for example the test which checks the restart kills the container while the other tests are running.

Would you be able to make this last change? Apologies for the back and forth.

@collinmurd

@collinmurd

Would you be able to make this last change? Apologies for the back and forth.

No worries! Thanks for catching the restart issue. Oracle is a pretty heavy process, running more than 4 or more containers would exceed my 8GB WSL limit. So I was trying to minimize the number of containers in parallel. This leaves with exactly 3 which should hopefully work on most people's machines.

@cristianrgreco

Thanks @collinmurd for the PR and your patience with the review!