feat(log/api): separate unexpected and expected logs by halibobo1205 · Pull Request #5624 · tronprotocol/java-tron
Conversation
| ShieldedTRC20Parameters shieldedTRC20Parameters = wallet | ||
| .createShieldedContractParameters(request); | ||
| responseObserver.onNext(shieldedTRC20Parameters); | ||
| } catch (ZksnarkException | ContractValidateException e) { |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of separating exceptions?
According to PR and issue, the purpose is not very clear.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unknown exception stacks need to be printed so that you can track down the problem easily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Labels
2 participants