fix: detect `git_push_create_all_pipelines` feature flag correctly by JounQin · Pull Request #214

fix: detect `git_push_create_all_pipelines` feature flag correctly by JounQin · Pull Request #214 · un-ts/changesets-gitlab

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces two changeset patches that address issues in the changesets-gitlab configuration. One patch fixes the detection of the git_push_create_all_pipelines feature flag while the other corrects the legacy types reference. Additionally, the package.json file is updated to change the type definitions path and bump several development dependencies. The runPublish function in src/run.ts is refactored to explicitly extract the active property from the feature flag API response while maintaining proper error handling.

Changes

File(s)	Summary
`.changeset/angry-phones-poke.md` `.changeset/silly-mugs-prove.md`	Introduces changeset patches for the changesets-gitlab category: fixes the detection of the `git_push_create_all_pipelines` feature flag and corrects legacy types reference.
`package.json`	Updates the type definitions path (from `./lib/index.d.ts` to `./index.d.cts`) and bumps devDependencies (`@1stg/common-config`, `@pkgr/rollup`, `eslint`, `typescript`).
`src/run.ts`	Refactors the `runPublish` function to use a `.then()` for extracting the `active` property from the API response before handling errors with `.catch()`.

Sequence Diagram(s)

sequenceDiagram
    participant R as runPublish Function
    participant F as FeatureFlags API

    R->>F: Call show('git_push_create_all_pipelines')
    alt Successful Response
      F-->>R: Return { active: true/false }
      R->>R: Extract and use `active` value
    else Error Occurred
      F-->>R: Return error
      R->>R: Catch error and default to false
    end

Possibly related PRs

feat: fetch the tags and push each one individually #195: Addresses similar feature flag detection issues, specifically for the git_push_create_all_pipelines feature flag.
chore: release package(s) #208: Involves modifications in handling the feature flag response within the publish flow, aligning with the changes in runPublish.

Poem

I hop through lines of updated code,
Fixing flags where secrets once abode.
Types now point to a brand new way,
With dev deps fresh to brighten the day.
I’m a clever rabbit on a coding spree! 🐇
Happy patches hopping, wild and free!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/run.ts

Oops! Something went wrong! :(

ESLint: 9.24.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@1stg/eslint-config' imported from /eslint.config.js
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d3b7d9 and 5d2a111.

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (4)

.changeset/angry-phones-poke.md (1 hunks)
.changeset/silly-mugs-prove.md (1 hunks)
package.json (3 hunks)
src/run.ts (1 hunks)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.