fix: env-var rule, allow any by ogzhanolguncu · Pull Request #5261 · unkeyed/unkey
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: e816fa2c-abe0-41f3-8d7d-cd83ada7dbdd
📒 Files selected for processing (1)
web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/advanced-settings/env-vars/schema.ts
📝 Walkthrough
Walkthrough
The regex constraint on the key field in the environment variable schema was removed. The validation now only enforces that the key is a non-empty string, eliminating the requirement that keys must start with a letter or underscore.
Changes
| Cohort / File(s) | Summary |
|---|---|
Schema Validation Update web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/advanced-settings/env-vars/schema.ts |
Removed regex pattern validation from the key field in envVarEntrySchema. The field now validates only with z.string().min(1, "Key is required") instead of the previous pattern requiring keys to start with a letter or underscore followed by alphanumeric characters or underscores. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | ⚠️ Warning | The description is largely incomplete. Critical sections are missing: no linked issue, unchecked type-of-change, placeholder testing instructions, and uncompleted checklist items. | Link a specific issue number, select the appropriate type of change, provide actual testing steps, and verify checklist items before merging. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly and concisely summarizes the main change: removing the arbitrary regex validation on environment variable keys to allow any value. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
- 📝 Generate docstrings (stacked PR)
- 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
fix-env-var-rule
Comment @coderabbitai help to get the list of available commands and usage tips.