fix: port scroll issue by ogzhanolguncu · Pull Request #5353 · unkeyed/unkey
📝 Walkthrough
Walkthrough
Two minor settings component enhancements: added an onWheelCapture handler to prevent accidental port number changes via mouse wheel scrolling, and added a max-width constraint to the setting description container for layout consistency.
Changes
| Cohort / File(s) | Summary |
|---|---|
Form Input Enhancement web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/runtime-settings/port-settings.tsx |
Added onWheelCapture event handler to Port FormInput that blurs the input on wheel events, preventing unintended number modifications from mouse scroll. |
Layout Styling web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/settings/components/shared/setting-description.tsx |
Applied max-w-[480px] CSS class to the outer container div to establish a maximum width constraint for the setting description component. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | ⚠️ Warning | The description lacks critical sections from the template including linked issue number, type of change checkboxes, testing instructions, and required checklist items. | Add the issue number (Fixes #), select the appropriate change type, provide detailed test instructions, and complete the required checklist items. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title 'fix: port scroll issue' accurately summarizes the main change—preventing scroll from affecting the port number input. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
- 📝 Generate docstrings (stacked PR)
- 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix-port-scroll-issue
📝 Coding Plan
- Generate coding plan for human review comments
Comment @coderabbitai help to get the list of available commands and usage tips.