chore: remove web ch tests by ogzhanolguncu · Pull Request #5358 · unkeyed/unkey
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 33693d04-4f0a-4f68-9128-80d40bcd0443
📒 Files selected for processing (1)
web/internal/clickhouse/package.json
📝 Walkthrough
Walkthrough
This PR removes the verification insertion capability from the ClickHouse module by eliminating the insertVerification function from the public API and deleting associated ClickHouse integration test suites.
Changes
| Cohort / File(s) | Summary |
|---|---|
Core API changes web/internal/clickhouse/src/index.ts, web/internal/clickhouse/src/verifications.ts, web/internal/clickhouse/package.json |
Removed insertVerification and its use (deleted insert entry from ClickHouse.verifications), dropped Inserter import usage, and removed the test script from package.json. |
Deleted integration tests web/internal/clickhouse/src/insert_verifications.test.ts, web/internal/clickhouse/src/verifications_billing.test.ts, web/internal/clickhouse/src/verification_outcomes_propagate_correctly.test.ts, web/internal/clickhouse/src/verification_tags.test.ts, web/internal/clickhouse/src/logs-timeseries.test.ts, web/internal/clickhouse/src/ratelimits_billing.test.ts |
Removed multiple Vitest-based end-to-end/integration tests covering verification insertion, billing, outcome propagation, tag handling, time-series aggregation, and ratelimit billing. |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | ⚠️ Warning | The PR description is essentially the repository template with all sections empty or filled with placeholders; no actual context, rationale, or testing details are provided for the significant changes made. | Complete the description by explaining why tests were removed, the impact on CI/testing, and whether this is a temporary or permanent change; also fill in the testing section with relevant details. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title 'chore: remove web ch tests' directly and accurately summarizes the main change—removing ClickHouse-related test files and test infrastructure from the web directory. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
remove-web-ch-tests
📝 Coding Plan
- Generate coding plan for human review comments
Comment @coderabbitai help to get the list of available commands and usage tips.