fix: show skipped deployment as skipped in overview by Flo4604 · Pull Request #5362 · unkeyed/unkey
📝 Walkthrough
Walkthrough
This PR adds support for a "skipped" deployment status. It introduces a new SkippedDeploymentView component to display when deployments are skipped, extends the deployment status enumeration to include "skipped", and modifies the deployment page to detect and render the skipped state with adjusted polling behavior.
Changes
| Cohort / File(s) | Summary |
|---|---|
New Skipped Deployment View Component web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/(deployment-progress)/skipped-deployment-view.tsx |
New functional React component that displays a UI for skipped deployments, including GitHub and Ban icons, descriptive text, and a dynamic link to project settings using workspaceSlug and projectId from hooks/params. |
Deployment Status Update web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/deployment-utils.ts |
Added "skipped" to DEPLOYMENT_STATUSES constant, enabling the type system to recognize "skipped" as a valid deployment status value. |
Deployment Page Integration web/apps/dashboard/app/(app)/[workspaceSlug]/projects/[projectId]/(overview)/deployments/[deploymentId]/page.tsx |
Integrated SkippedDeploymentView component with conditional rendering logic; disabled polling when deployment is skipped; updated status derivation to force "skipped" state when applicable; refined query configuration with explicit enabled flag and disabled refetch on window focus. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~12 minutes
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | ⚠️ Warning | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title accurately summarizes the main change: adding support for showing skipped deployments in the deployment overview. |
| Description check | ✅ Passed | The PR description comprehensively covers what the PR does, includes implementation details, testing instructions, and properly marks the type of change as 'New feature'. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
- 📝 Generate docstrings (stacked PR)
- 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
03-17-fix_show_skipped_deployment_as_skipped_in_overview
📝 Coding Plan
- Generate coding plan for human review comments
Comment @coderabbitai help to get the list of available commands and usage tips.