fix: npm installation error by rubiin · Pull Request #1697 · validatorjs/validator.js

@rubiin

Updated rollup to solve installation error

Checklist

  • PR contains only changes related; no stray files, etc.
  • [] README updated (where applicable)
  • [] Tests written (where applicable)

@rubiin

@codecov

@rubiin

rollup latest version doesnot seem to support older versions. Also node 6.0 is way old i think we should drop tests for it as its likely someone is using that

fedeci

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if node 6 may not be used anymore this is a breaking change and should be released in a new major.

@rubiin

Even if node 6 may not be used anymore this is a breaking change and should be released in a new major.

however its a blocker if you cant install the package dependencies after forking. @profnandaa

@rubiin

@rubiin

tested on node v10,12 and v14.

@profnandaa

Don't leave out Node 6 yet, there's a time it helped us catch an old browser incompatibility, see #1357

@rubiin

@rubiin

@profnandaa fixed it without breaking support for node 6

@profnandaa

profnandaa

@rubiin

@profnandaa should i also make a pr to update eslint and some tools. They are way old