fix(validators): fix isdate format validation by flymans · Pull Request #1711 · validatorjs/validator.js
allow users to strictly validate dates with "." as delimiter.
Closes #1709
Checklist
- PR contains only changes related; no stray files, etc.
- README updated (where applicable)
- Tests written (where applicable)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR @flymans
LGTM 🎉
isDate documentation is ambiguous, we should probably state that delimiters array can only include / . or - or may be refactor the validator in a way we can pass any delimiter as an option. I will probably open an issue to discuss it cc @profnandaa
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contrib! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters