refactor: run scripts in parallel for build and clean by sachinraja · Pull Request #1747

refactor: run scripts in parallel for build and clean by sachinraja · Pull Request #1747 · validatorjs/validator.js

Run building for browser, node, and es in parallel. Same for clean. This speeds up both commands.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

		"clean:es": "rimraf es",
		"clean:browser": "rimraf validator*.js",
		"clean": "npm run clean:node && npm run clean:browser && npm run clean:es",
		"clean": "run-p clean:*",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the same result achieved using a single & and without having to add another dep?

	"clean": "run-p clean:*",
	"clean": "npm run clean:node & npm run clean:browser & npm run clean:es",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't work on Windows (with cmd.exe)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, shitty cmd🙃

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, just curious, what is does the ready-to-land label mean? If something is ready to land, can't it just be merged?

@sachinraja it's an internal way of organizing things between the project collaborators.

The goal of the label is to let project maintainers know that this PR has already been reviewed by a collaborator and that there is no objection to it being merged.

Later when enough PRs have been stacked, a maintainer will merge your PR alongside other ready-to-land PRs and create a new release as you can see in this release staging PR #1650.

Got it, thanks for explaining @tux-tn