Fixes #1761 for Bangladesh and Myanmar Mobile Validation and Test by ferdousulhaque · Pull Request #1813 · validatorjs/validator.js
Fixes and Addition, please ignore the previous pull request.
- Bangladesh Mobile Number validation was incorrect, fixed that and added test for the relevant part.
- Added new Myanmar Mobile Number validation and test
- Updated README.md for the new country Myanmar
Checklist
- PR contains only changes related; no stray files, etc.
- README updated (where applicable)
- Tests written (where applicable)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @ferdousulhaque and thank you for your PR!
Can you please address the comments below?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thank you for addressing my comments. Can you please fix merge conflicts and we should be good to go
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 Thank you
@tux-tn Please help to add tag hacktoberfest-accepted. Thank you a lot 🎉
This was referenced
Jun 12, 2024This was referenced
Jun 14, 2024This was referenced
Jun 20, 2024This was referenced
Jul 10, 2024This was referenced
Jul 19, 2024This was referenced
Aug 30, 2024This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters