feat(isAlpha, isAlphanumeric): add Japanese locale(ja-JP) by starcharles · Pull Request #2014 · validatorjs/validator.js

@starcharles

Hello!
I added Japanese locale(ja-JP) to isAlpha/isAlphanumeric.
Please review my PR!!

Thanks in advance.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@starcharles

@codecov

Codecov Report

Merging #2014 (c6905f5) into master (1bb14e8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2014   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2203      2203           
  Branches       477       477           
=========================================
  Hits          2203      2203           
Impacted Files Coverage Δ
src/lib/alpha.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rubiin

profnandaa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉 I'd never noticed that we didn't have ja-JP locale for isAlpha/numeric.

@nshaikhinurov

Hey guys, I'm wondering when that will be published as a next release version?

LGTM, thanks for your contrib! 🎉 I'd never noticed that we didn't have ja-JP locale for isAlpha/numeric.

This was referenced

Jun 3, 2024

This was referenced

Jun 12, 2024

This was referenced

Jun 14, 2024

This was referenced

Jun 20, 2024

This was referenced

Jul 10, 2024

This was referenced

Jul 19, 2024

This was referenced

Aug 30, 2024