Home Original page

[Varnika|Yashna] Fix. IPv6 format is fixed by VarnikaB · Pull Request #2083 · validatorjs/validator.js

@VarnikaB

Fixed the invalid IPv6 address format:

  • BC:e4d5:c:e7b9::%40i0nccymtl9cwfKo.5vaeXLSGRMe:EDh2qs5wkhnPws5xQKqafjfAMm6wGFCJ.bVFsZfb
  • 1dC:0DF8:62D:3AC::%KTatXocjaFVioS0RTNQl4mA.V151o0RSy.JIu-D-D8.d3171ZWsSJ7PK4YjkJCRN0F
    as invalid

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

"fixes #2039"

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (531dc7f) to head (36b555c).
Report is 145 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #2083   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2308           
  Branches       578       578           
=========================================
  Hits          2308      2308

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

WikiRik

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new IP addresses that are invalid to the tests

@VarnikaB

@VarnikaB

I have added the test cases

@VarnikaB

I have added the test cases could you please approve it soon.

rubiin

@profnandaa

Can fix the merge conflict, other than that, LGTM. Thanks for your contrib!

@WikiRik

Closing this in favour of #2453