feat(isLicensePlate): Updated isLicensePlate to accept real pt-PT license plates. by castrosu · Pull Request #2555 · validatorjs/validator.js

Conversation

@castrosu

I have updated the isLicensePlate pt-PT regex to accept actual valid license plates in Portugal.

Image as an example of valid license plates.
image

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8d58ecb) to head (c441418).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2555   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2535      2535           
  Branches       641       641           
=========================================
  Hits          2535      2535           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WikiRik

Can you provide a link to the source where you made the screenshot from?

@castrosu

WikiRik

@castrosu

can someone approve this? without this the current regex check doesn't pass all tests for pt-PT license plate in this PR

WikiRik

rubiin