feat(layers) Port ColumnLayer to WebGPU by ibgreen · Pull Request #10122 · visgl/deck.gl
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
| modules: [project32, flatShading ? phongMaterial : gouraudMaterial, picking, columnUniforms] |
In WebGPU, this layer now assembles column-layer.wgsl.ts, but that shader reads color.opacity and calls deckgl_premultiplied_alpha while getShaders() only registers project32, the material module, picking, and columnUniforms. Because no color WGSL source is included, the assembled shader has no color symbol or premultiplied-alpha helper, so creating a ColumnLayer (and therefore GridCellLayer, which subclasses it) on WebGPU fails at shader compilation time.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".