fix: show warning for non-web targets by snitin315 · Pull Request #3094 · webpack/webpack-dev-server
Conversation
- This is a bugfix
- This is a feature
- This is a code refactor
- This is a test update
- This is a docs update
- This is a metadata update
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
fixes #2104
Breaking Changes
None
Additional Info
None
| if (this.options.liveReload) { | ||
| this.logger.info(`Live reload will not work with a non-web target.`); | ||
| } | ||
| } |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is warning, also better keep it inside DevServerPlugin, in future webpack-dev-server will be plugin, so we need put logic inside plugin
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters