fix: use correct port for https reverse proxy by qswinson · Pull Request #4293 · webpack/webpack-dev-server
Conversation
- This is a bugfix
- This is a feature
- This is a code refactor
- This is a test update
- This is a docs update
- This is a metadata update
For Bugs and Features; did you add new tests?
New test cases have been added
Motivation / Use-Case
This solves #4292 where the port of the webpack dev server is used instead of the port from the location in https situations.
Breaking Changes
no breaking changes
Additional Info
The committers are authorized under a signed CLA.
- ✅ Quenby Mitchell (23dc6f4)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is breaking change and breaks URLs for local development
It is breaking change and breaks URLs for local development
Can you provide a test case for the test suite that you say is breaking so I can address it? All of the unit tests are passing. The current behavior is a breaking change from Webpack v4 and is preventing us from upgrading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
2 participants