Update release checklist template by swissspidy · Pull Request #5850 · wp-cli/wp-cli

@swissspidy

Based on yesterday's experience

@swissspidy

danielbachhuber

md5 hash verified: 179fc8dacbfe3ebc2d00ba57a333c982
New version works. Proceeding to replace.
Success: Updated WP-CLI to 1.4.0.
$ wp @daniel option get home

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was meant as a smoke test...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A smoke test that only works on your machine :-)

What‘s a good alternative?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

$ wp cli version
WP-CLI 2.8.1
$wp eval 'echo \WP_CLI\Utils\http_request( "GET", "https://api.wordpress.org/core/version-check/1.6/" )->body;' --skip-wordpress
<PHP serialized string with version numbers>

That would at the very least test whether the update worked and whether regular execution and the integration with Requests works.
Note: The above example that Daniel provided mostly just tested the SSH subsystem. The entire option retrieval logic is executed on whatever version is installed on his server.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Daniel Bachhuber <daniel.bachhuber@automattic.com>

@swissspidy

schlessera

md5 hash verified: 179fc8dacbfe3ebc2d00ba57a333c982
New version works. Proceeding to replace.
Success: Updated WP-CLI to 1.4.0.
$ wp @daniel option get home

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

$ wp cli version
WP-CLI 2.8.1
$wp eval 'echo \WP_CLI\Utils\http_request( "GET", "https://api.wordpress.org/core/version-check/1.6/" )->body;' --skip-wordpress
<PHP serialized string with version numbers>

That would at the very least test whether the update worked and whether regular execution and the integration with Requests works.
Note: The above example that Daniel provided mostly just tested the SSH subsystem. The entire option retrieval logic is executed on whatever version is installed on his server.

@danielbachhuber

danielbachhuber

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving our docs!