Fix breaking multi-line CSV values on reading by Takshil-Kunadia · Pull Request #5939 · wp-cli/wp-cli
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @Takshil-Kunadia !
Can you include some tests for this change? PHPUnit or Behat tests would be fine.
Thanks! @danielbachhuber . I have added Unit test for CSV Iterator and added basic tests along with the test that covers the intended scenario. Please review...
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and the tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters