Home Original page

Fix various compiler warnings by aroffringa · Pull Request #2801 · xtensor-stack/xtensor

Conversation

@aroffringa

These solve warnings when compiled with gcc 14 using a set of warnings enabled that we use in one of our projects:
-Wall
-Wnon-virtual-dtor
-Wzero-as-null-pointer-constant
-Wduplicated-branches
-Wundef
-Wvla
-Wpointer-arith
-Wextra
-Wno-unused-parameter

Checklist

  • The title and commit message(s) are descriptive.
  • Small commits made to fix your PR have been squashed to avoid history pollution.
  • Tests have been added for new features or bug fixes.
  • API of new functions and classes are documented.

Description

@aroffringa

I note this overlaps to some part with #2781; is there a reason that PR has not been merged?

These solve warnings when compiled with gcc 14 using a set of warnings enabled that we use in one of our projects:
  -Wall
  -Wnon-virtual-dtor
  -Wzero-as-null-pointer-constant
  -Wduplicated-branches
  -Wundef
  -Wvla
  -Wpointer-arith
  -Wextra
  -Wno-unused-parameter

JohanMabille

// in compilation error for expressions that do not provide a SIMD interface.
// simd_assign is true if simd_linear_assign() or simd_linear_assign(de1, de2)
// is true.
if constexpr(simd_assign) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is C++17 while we advertise that xtensor is compatible with C++14.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's good to know. I've changed the fix by using #pragma GCC statements to not get the warning.

2 participants

@aroffringa @JohanMabille