fix: take into account aliases when appending arrays from config obje…

fix: take into account aliases when appending arrays from config obje… · yargs/yargs-parser@f8a2d3f

2 files changed

lines changed

Original file line number	Diff line number	Diff line change
`@@ -555,7 +555,7 @@ function parse (args, opts) {`
`555`	`555`	`} else {`
`556`	`556`	`// setting arguments via CLI takes precedence over`
`557`	`557`	`// values within the config file.`
`558`		`-if (!hasKey(argv, fullKey.split('.')) \|\| (flags.arrays[fullKey] && configuration['combine-arrays'])) {`
	`558`	`+if (!hasKey(argv, fullKey.split('.')) \|\| (checkAllAliases(fullKey, flags.arrays) && configuration['combine-arrays'])) {`
`559`	`559`	`setArg(fullKey, value)`
`560`	`560`	`}`
`561`	`561`	`}`

Original file line number	Diff line number	Diff line change
`@@ -774,6 +774,21 @@ describe('yargs-parser', function () {`
`774`	`774`	`argv.should.have.property('foo', 'bar')`
`775`	`775`	`argv.should.have.property('bar', 'baz')`
`776`	`776`	`})`
	`777`	`+`
	`778`	`+it('should combine array typed options with alias and camel-case', function () {`
	`779`	`+var argv = parser(['--camEl', 'foo', '--camEl', 'bar', '-a', 'red'], {`
	`780`	`+array: ['cam-el', 'apple'],`
	`781`	`+alias: { apple: 'a' },`
	`782`	`+configObjects: [{ camEl: 'baz' }, { a: 'sweet' }],`
	`783`	`+configuration: {`
	`784`	`+'combine-arrays': true,`
	`785`	`+'camel-case-expansion': true`
	`786`	`+}`
	`787`	`+})`
	`788`	`+`
	`789`	`+argv['cam-el'].should.deep.equal(['foo', 'bar', 'baz'])`
	`790`	`+argv.apple.should.deep.equal(['red', 'sweet'])`
	`791`	`+})`
`777`	`792`	`})`
`778`	`793`
`779`	`794`	`describe('dot notation', function () {`