[S] Change in code/re2[main]: .bcr: fix windows command-line flags

Russ Cox (Gerrit)

unread,

Aug 13, 2025, 5:57:35 PM8/13/25

to Jeremy Kun, re2...@googlegroups.com

Attention needed from Jeremy Kun

Russ Cox has uploaded the change for review

Russ Cox would like Jeremy Kun to review this change.

Commit message

.bcr: fix windows command-line flags

Change-Id: I9fe55a5db9c7080b818d8b4411982ad4e65d50f5

Change information

Files:

  • M .bcr/presubmit.yml

Change size: S

Delta: 1 file changed, 25 insertions(+), 3 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

  • Jeremy Kun

Submit Requirements:

  • Code-Review
  • Review-Enforcement

Jeremy Kun (Gerrit)

unread,

Aug 13, 2025, 6:03:21 PM8/13/25

to Russ Cox, re2...@googlegroups.com

Attention needed from Russ Cox

Jeremy Kun voted and added 1 comment

Votes added by Jeremy Kun

1 comment

Patchset-level comments

Open in Gerrit

Related details

Attention is currently required from:

  • Russ Cox

Submit Requirements:

  • Code-Review
  • Review-Enforcement

Russ Cox (Gerrit)

unread,

Sep 29, 2025, 4:14:49 PM9/29/25

to Alan Donovan, Jeremy Kun, re2...@googlegroups.com

Attention needed from Alan Donovan and Jeremy Kun

Russ Cox added 1 comment

Russ Cox

What changed is RE2 updated to requiring C++17.

Open in Gerrit

Related details

Attention is currently required from:

  • Alan Donovan
  • Jeremy Kun

Submit Requirements:

  • Code-Review
  • Review-Enforcement

Alan Donovan (Gerrit)

unread,

Sep 29, 2025, 4:46:38 PM9/29/25

to Russ Cox, Jeremy Kun, re2...@googlegroups.com

Attention needed from Jeremy Kun and Russ Cox

Alan Donovan voted Code-Review+2

Attention is currently required from:

  • Jeremy Kun
  • Russ Cox

Submit Requirements:

  • Code-Review
  • Review-Enforcement

Russ Cox (Gerrit)

unread,

Sep 29, 2025, 5:57:50 PM9/29/25

to Alan Donovan, Jeremy Kun, re2...@googlegroups.com

Russ Cox submitted the change

Change information

Commit message:

.bcr: fix windows command-line flags

Change-Id: I9fe55a5db9c7080b818d8b4411982ad4e65d50f5

Files:

  • M .bcr/presubmit.yml

Change size: S

Delta: 1 file changed, 25 insertions(+), 3 deletions(-)

Branch: refs/heads/main

Submit Requirements:

  • Code-Review: +2 by Alan Donovan, +1 by Jeremy Kun

Open in Gerrit