Home Original page

[python-committers] Deny nonbreaking spaces in the precommit script?

Łukasz Langa lukasz at langa.pl
Mon Nov 8 13:18:54 CET 2010 
Am 08.11.2010 12:55, schrieb Michael Foord:
> On 08/11/2010 11:42, Senthil Kumaran wrote:
>> We can just customize our environments. It is easy.

I already pointed out in my last post why that's not going to solve the 
problem.

> Additional checks could be put in `make patchcheck` or a local commit 
> hook for hg.

Automation always pays off. Simplifying the process always pays off. 
Providing yet another step to the workflow would be a move in the 
opposite direction*. Is there any point in weighing each time whether a 
mistake is common enough to be included in the commit hooks? It's not 
like we're paying some SVN vendor a fee per hook ;-)

* A completely separate topic would be that programmer-side precommit 
hooks are a terrific idea for Hg. But just as client-side form 
validation doesn't free Web apps from having to implement server-side as 
well, I believe hooks on the central repository should be as complete 
and as restrictive as it gets.

-- 
Best regards,
Łukasz Langa
More information about the python-committers mailing list