Home Original page

[python-committers] [Core-mentorship] Regarding reviewing test cases written for tabnanny module

Chris Jerdonek chris.jerdonek at gmail.com
Tue Apr 11 02:29:16 EDT 2017 
On Mon, Apr 10, 2017 at 8:55 PM, Martin Panter <vadmium+py at gmail.com> wrote:
> In this particular pull request, I think the submitter has rebased
> their commit, and force-pushed it. These days, I notice Git Hub seems
> to forget old commits pretty soon after you force-push the branch they
> are on. I don't think you can "unsquash" them retrospectively; you
> would need a copy of the old commits saved somewhere.

In the past, after force-pushing on GitHub, I've noticed that
"orphaned" commits can still be accessed as long as you remember the
previous URL / SHA. For example, in this case, clicking "View Changes"
goes to an URL that doesn't show anything:

https://github.com/python/cpython/pull/851/files/d66ae892c51ab84eac71a3f1b558a021a9cc7a0b

While the commit isn't visible under the pull-request URL, it can
still be accessed through the following two URLs (in the proposer's
repo and in the target repo):

https://github.com/ultimatecoder/cpython/commit/d66ae892c51ab84eac71a3f1b558a021a9cc7a0b
https://github.com/python/cpython/commit/d66ae892c51ab84eac71a3f1b558a021a9cc7a0b

I'm not sure if this helps though because the inline comments don't
seem to be present in this URL.

--Chris



>
> Other times people add revised commits on top of their old commits,
> which would have been easier for me in this situation, but I suspect
> that makes it harder for the person pushing the final change if they
> have to squash it into a single commit. (I noticed the eventual commit
> message is often messy, redundant, automatically generated, etc.)
> _______________________________________________
> python-committers mailing list
> python-committers at python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
More information about the python-committers mailing list