Home Original page

[python-committers] [Core-mentorship] Regarding reviewing test cases written for tabnanny module

Terry Reedy tjreedy at udel.edu
Tue Apr 11 14:30:29 EDT 2017 
On 4/11/2017 1:21 PM, Donald Stufft wrote:
>
>> On Apr 11, 2017, at 12:25 PM, Terry Reedy <tjreedy at udel.edu
>> <mailto:tjreedy at udel.edu>> wrote:

>> I was under the impression that the green [commit] button would do the
>> squashing.   Or at least that it could.
>>
>
> Yes it can, and IIRC for CPython we have it set so it _only_ does that.
> Although the commit message may be ugly if you don’t adjust it in the
> text editor that pops up when GitHub asks you to confirm the merge since
> it by default just concats all of the commit messages into a list so you
> might get a commit message like:
>
> * implement feature
>
> * fix thing
>
> * ugh
>
> * address review
>
> Instead of a nice clean one. That’s going to be up to the person hitting
> the merge button to edit the commit message to be clean though.

I think committers should always be responsible for the commit message. 
This will usually mean editing submissions from non-committers.  Since 
message is truncated to first line in some displays, the latter should 
summarize main point of commit.
More information about the python-committers mailing list