Home Original page

[python-committers] Regarding reviewing test cases written for tabnanny module

Nick Coghlan ncoghlan at gmail.com
Fri Apr 14 10:02:11 EDT 2017 
On 12 April 2017 at 01:57, Guido van Rossum <guido at python.org> wrote:
> On Tue, Apr 11, 2017 at 7:42 AM, Nick Coghlan <ncoghlan at gmail.com> wrote:
>>
>> Since we do the squash & merge to get an atomic commit at the end, it
>> doesn't make sense to do any force pushes along the way.
>
>
> I was going to argue with this, but then I realized you're right. We
> shouldn't need rebase any more, merge should be fine for all situations. (I
> can think of exceptions but they aren't worth mentioning.)

That was exactly my reaction when Serhiy pointed it out - I started to
argue the point, but then invalidated all my own arguments before
actually posting anything :)

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia
More information about the python-committers mailing list