Home Original page

[python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

Terry Reedy tjreedy at udel.edu
Wed Aug 2 23:01:59 EDT 2017 
Rearranging things in order. I asked
 >     Do people on a team have to be core-developers?

The broader question is whether active people who want notifications 
have to be a committer to get automatic notifications of a PR and in 
particular a review request.  It appears that anyone with a github 
account can review python PRs and that anyone who does submit a review, 
as opposed to comments, gets listed under Reviews.

Moreover, we *want* more reviews from non-committer contributors.  To 
encourage this, Martin Loewis once offered to review any patch in 
exchange for 5 reviews by such people, even if brief.  I understood that 
the hope of getting more such reviews was one of the reasons for the switch.

> On Wed, Aug 2, 2017 at 2:47 PM, Steve Dower <steve.dower at python.org 
> <mailto:steve.dower at python.org>> wrote:

>     I have no strong opinion about core vs non-core dev, but I think
>     part of the point of the distinction is reflected here. Why would we
>     notify someone about every PR in an area if we don’t want them to be
>     committers?

I not sure what 'them' you are speaking of.  I am thinking about active 
contributors who are potential committers.  Part of becoming a committer 
is demonstrating the ability to do committer-qualify reviews.

On 8/2/2017 7:06 PM, Senthil Kumaran wrote:
 > Only committers can merge stuff. So, that would make a requirement that
 > reviewers  (and @team-of-reviwers)should be core-dev / committers.

If we were using the list as an actual 'code owner' list, I would not 
have asked.  But it was said that we are not using it that way and that 
there is no plan to turn on the 'owner' feature.

--
Terry Jan Reedy
More information about the python-committers mailing list