Home Original page

[python-committers] Please edit the commit message when merge a PR

Victor Stinner victor.stinner at gmail.com
Mon Jul 10 10:57:43 EDT 2017 
I would prefer to ask the author to squash and/or rebase his/her
commits rather than having to edit the commit message myself. I prefer
that the commit message is part of the review, and not only done by
the one who clicks on the Merge button.

It would prefer mistakes in the commit message.

GitHub PR UI is not ideal to review commit messages :-/

Victor

2017-07-10 15:14 GMT+02:00 Serhiy Storchaka <storchaka at gmail.com>:
> When a PR is consistent on several commits, the final commit message
> composed by GitHub contains messages of all these commits: "fix typo",
> "address yyy comments", "revert zzz". If the initial commit message
> contained errors (e.g. absent issue number), it is easy to edit the title
> and text of a PR, but the initial commit message lefts unchanged. GitHub
> allows to edit the commit message of squashed commit, and please don't
> ignore this possibility. Otherwise the commit message in the repository will
> be ugly if not worse.
>
> _______________________________________________
> python-committers mailing list
> python-committers at python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
More information about the python-committers mailing list