Victor Stinner victor.stinner at gmail.com
Tue Jul 11 04:14:42 EDT 2017

• Previous message (by thread): [python-committers] Please edit the commit message when merge a PR
• Next message (by thread): [python-committers] Core sprint 2017 - Sep 4 - Sep 9, Menlo Park, California
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

2017-07-10 17:35 GMT+02:00 Guido van Rossum <guido at python.org>:
> Often the committer has more context to write a proper commit message, and
> asking the contributor to do the squash is just wasting time (plus in
> general we *don't* want contributors to squash, since that loses the context
> for the review). So I'm with Sergey. This is how we do it in the
> mypy-related projects.

Oh, I noticed that comments were hidden after a rebase or squash. But
I never understood the link between squash/rebase and hidden comments.

Ok, it makes sense to prefer merge and multiple commits to workaround
UI limitations of GitHub PRs :-)

Victor

---

• Previous message (by thread): [python-committers] Please edit the commit message when merge a PR
• Next message (by thread): [python-committers] Core sprint 2017 - Sep 4 - Sep 9, Menlo Park, California
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the python-committers mailing list